fix: use data.url instead of data['og:url'] in html utils#40
Open
4msar wants to merge 1 commit intoHashnode:developmentfrom
Open
fix: use data.url instead of data['og:url'] in html utils#404msar wants to merge 1 commit intoHashnode:developmentfrom
4msar wants to merge 1 commit intoHashnode:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue occurred in my blog where the urls are correct before the embed preview comes
after the embeds preview generated the links are broken maybe this issue is comes from the hashnode-core but instead of
og:urlhere I usedata.urlso the embed preview can use the original url.Issue happens in here: https://blog.msar.me/tutorials
Original link: https://blog.msar.me/series/laravel - works fine
Rendered link: https://hashnode.com/series/laravel-clo9xy1bz07vi7bnv92y77mmr - getting 404